fix interaction between top_k and ignore_index
#1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Mar 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
========================================
- Coverage 88% 51% -37%
========================================
Files 225 225
Lines 11904 11905 +1
========================================
- Hits 10460 6044 -4416
- Misses 1444 5861 +4417 |
Borda
changed the title
top_k and ignore_index
justusschock
approved these changes
Mar 6, 2023
stancld
approved these changes
Mar 6, 2023
Borda
pushed a commit
that referenced
this pull request
Mar 10, 2023
* fix code * changelog * fix tests (cherry picked from commit 0d28f26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1556
Fixes an cornercase when
top_k>1andignore_index!=None. The case was not tested, but test have been added now.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃